new TCP installation problems

[Jeff Gilliam]

Is it only me, or has anyone else had problems installing the new TCP
sources?

1) The new netinet/in.h no longer declares ntohl() and friends, causing
   lint to complain bitterly.

2) sbreserve() returns a value which is ignored in netns/spp_usrreq.c

3) m_free() returns a value which is ignored in netns/spp_usrreq.c

4) There is some type confusion about the arguments to sbreserve() and
   soreserve(), basically int vs. u_long stuff.

None of these is hard to fix, but it makes me wonder: do I have different
4.3 sources than everyone else, or am I the only one who ever uses lint?

The lint output I get (with the ntohl() et al complaints edited out) is:

sbreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(345)  ::  ../net/raw_cb.c(54)
sbreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(345)  ::  ../net/raw_cb.c(56)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netinet/tcp_usrreq.c(393)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netinet/tcp_usrreq.c(393)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netinet/udp_usrreq.c(278)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netinet/udp_usrreq.c(278)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/idp_usrreq.c(389)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/idp_usrreq.c(389)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/idp_usrreq.c(540)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/idp_usrreq.c(540)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/spp_usrreq.c(1215)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../netns/spp_usrreq.c(1215)
sbreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(345)  ::  ../sys/uipc_socket.c(675)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../sys/uipc_usrreq.c(295)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../sys/uipc_usrreq.c(295)
soreserve, arg. 2 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../sys/uipc_usrreq.c(299)
soreserve, arg. 3 used inconsistently	../sys/uipc_socket2.c(324)  ::  ../sys/uipc_usrreq.c(299)
m_free returns value which is sometimes ignored
tcp_maxidle used( ???(105) ), but not defined
sbreserve returns value which is sometimes ignored
-- 

Jeff Gilliam	{ucbvax,pyramid,nsc}!voder!jeff