jove 4.9 (bug in iproc-ptys.c (read_proc))

Rob McMahon cudcv at warwick.ac.uk
Sat Sep 10 21:03:17 AEST 1988


Jove declares an unsigned int, assigns the return value from read to it,
and then compares it against -1.  There are machines (e.g. the Gould)
where this will never be true, and since read returns an int delcaring
this variable as unsigned seems odd in the first place.

RCS file: iproc-ptys.c,v
retrieving revision 1.1
diff -c -r1.1 iproc-ptys.c
*** /tmp/,RCSt1a01956	Sat Sep 10 12:02:15 1988
--- iproc-ptys.c	Sat Sep 10 12:01:52 1988
***************
*** 90,96 ****
  register int	fd;
  {
  	register Process	*p;
! 	unsigned int	n;
  	char	ibuf[1024];
  
  	for (p = procs; p != 0; p = p->p_next)
--- 90,96 ----
  register int	fd;
  {
  	register Process	*p;
! 	register int	n;
  	char	ibuf[1024];
  
  	for (p = procs; p != 0; p = p->p_next)
-- 
UUCP:   ...!mcvax!ukc!warwick!cudcv	PHONE:  +44 203 523037
JANET:  cudcv at uk.ac.warwick             ARPA:   cudcv at warwick.ac.uk
Rob McMahon, Computing Services, Warwick University, Coventry CV4 7AL, England



More information about the Comp.sources.bugs mailing list